watchdog: mena21: Do not use device pointer from struct watchdog_device (07352366) · Commits · 戴 / test

The device pointer in struct watchdog_device has a different lifetime than the driver code and should not be used in drivers. Use the pointer to the parent device instead. Signed-off-by:

Guenter Roeck <linux@roeck-us.net> Signed-off-by:

Wim Van Sebroeck <wim@iguana.be>

drivers/watchdog/mena21_wdt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -100,12 +100,12 @@ static int a21_wdt_set_timeout(struct watchdog_device *wdt,
		struct a21_wdt_drv *drv = watchdog_get_drvdata(wdt);

		if (timeout != 1 && timeout != 30) {
		dev_err(wdt->dev, "Only 1 and 30 allowed as timeout\n");
		dev_err(wdt->parent, "Only 1 and 30 allowed as timeout\n");
		return -EINVAL;
		}

		if (timeout == 30 && wdt->timeout == 1) {
		dev_err(wdt->dev,
		dev_err(wdt->parent,
		"Transition from fast to slow mode not allowed\n");
		return -EINVAL;
		}

Admin message