Commit 072623de authored Apr 09, 2016 by Mikulas Patocka Committed by Mike Snitzer Apr 11, 2016

dm: fix dm_target_io leak if clone_bio() returns an error



Commit c80914e8 ("dm: return error if bio_integrity_clone() fails
in clone_bio()") changed clone_bio() such that if it does return error
then the alloc_tio() created resources (both the bio that was allocated
to be a clone and the containing dm_target_io struct) will leak.

Fix this by calling free_tio() in __clone_and_map_data_bio()'s
clone_bio() error path.

Fixes: c80914e8 ("dm: return error if bio_integrity_clone() fails in clone_bio()")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent bf162006

drivers/md/dm.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1662,8 +1662,10 @@ static int __clone_and_map_data_bio(struct clone_info ci, struct dm_target ti,
		tio = alloc_tio(ci, ti, target_bio_nr);
		tio->len_ptr = len;
		r = clone_bio(tio, bio, sector, *len);
		if (r < 0)
		if (r < 0) {
		free_tio(ci->md, tio);
		break;
		}
		__map_bio(tio);
		}

Admin message