Commit 07105202 authored Jan 08, 2010 by Michal Marek

Makefile: do not override LC_CTYPE



Setting LC_CTYPE=C breaks localized messages in some setups. With only
LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not
so defined character classes and tolower()/toupper(). The former is not
a big issue, because we can assume that e.g. [:alpha:] will always
include a-zA-Z and we only ever process ASCII input. The latter seems
only affect arch/sh/tools/gen-mach-types, which we can handle separately.

So after this patch the meaning of ranges like [a-z], the behavior of
sort and join, etc. should be the same everywhere and at the same time
gcc should be able to print localized waring and error messages.
LC_NUMERIC=C might not be necessary, but setting it doesn't hurt.

Reported-by: Simon Horman <horms@verge.net.au>
Reported-by: Sergei Trofimovich <slyfox@inbox.ru>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Tested-by: Simon Horman <horms@verge.net.au>
Tested-by: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>

parent 1373411a

Makefile

+1 −2

Original line number	Diff line number	Diff line
		@@ -18,10 +18,9 @@ MAKEFLAGS += -rR --no-print-directory

		# Avoid funny character set dependencies
		unexport LC_ALL
		LC_CTYPE=C
		LC_COLLATE=C
		LC_NUMERIC=C
		export LC_CTYPE LC_COLLATE LC_NUMERIC
		export LC_COLLATE LC_NUMERIC

		# We are using a recursive build, so we need to do a little thinking
		# to get the ordering right.

arch/sh/tools/Makefile

+1 −1

Original line number	Diff line number	Diff line
		@@ -13,4 +13,4 @@
		include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types
		@echo ' Generating $@'
		$(Q)mkdir -p $(dir $@)
		$(Q)$(AWK) -f $^ > $@ \|\| { rm -f $@; /bin/false; }
		$(Q)LC_ALL=C $(AWK) -f $^ > $@ \|\| { rm -f $@; /bin/false; }

Admin message