Commit 06ee9da6 authored Oct 20, 2018 by Quentin Monnet Committed by Daniel Borkmann Oct 21, 2018

tools: bpftool: print nb of cmds to stdout (not stderr) for batch mode



When batch mode is used and all commands succeeds, bpftool prints the
number of commands processed to stderr. There is no particular reason to
use stderr for this, we could as well use stdout. It would avoid getting
unnecessary output on stderr if the standard ouptut is redirected, for
example.

Reported-by: David Beckett <david.beckett@netronome.com>
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 882731e0

tools/bpf/bpftool/main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -321,7 +321,8 @@ static int do_batch(int argc, char **argv)
		p_err("reading batch file failed: %s", strerror(errno));
		err = -1;
		} else {
		p_info("processed %d commands", lines);
		if (!json_output)
		printf("processed %d commands\n", lines);
		err = 0;
		}
		err_close:

Admin message