Commit 06e79976 authored Aug 25, 2009 by Paul E. McKenney Committed by Ingo Molnar Aug 26, 2009

rcu: Remove lockdep annotations from RCU's _notrace() API members

The lockdep annotations rcu_read_acquire() and rcu_read_release()
might lead to infinite looping if called from lockdep.  So this patch
removes them.  Formal repost of http://lkml.org/lkml/2009/8/25/309


on the strength of Lai Jiangshan's review.

Suggested-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Suggested-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: dipankar@in.ibm.com
Cc: akpm@linux-foundation.org
Cc: josht@linux.vnet.ibm.com
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: peterz@infradead.org
Cc: rostedt@goodmis.org
LKML-Reference: <20090826015337.GA18904@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent c935a331

include/linux/rcupdate.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -195,7 +195,6 @@ static inline notrace void rcu_read_lock_sched_notrace(void)
		{
		preempt_disable_notrace();
		__acquire(RCU_SCHED);
		rcu_read_acquire();
		}

		/*
		@@ -211,7 +210,6 @@ static inline void rcu_read_unlock_sched(void)
		}
		static inline notrace void rcu_read_unlock_sched_notrace(void)
		{
		rcu_read_release();
		__release(RCU_SCHED);
		preempt_enable_notrace();
		}

Admin message