Btrfs: Change btrfs_truncate_inode_items to stop when it hits the inode (06d9a8d7) · Commits · 戴 / test

btrfs_truncate_inode_items is setup to stop doing btree searches when it has finished removing the items for the inode. It used to detect the end of the inode by looking for an objectid that didn't match the one we were searching for. But, this would result in an extra search through the btree, which adds extra balancing and cow costs to the operation. This commit adds a check to see if we found the inode item, which means we can stop searching early. Signed-off-by:

Chris Mason <chris.mason@oracle.com>

fs/btrfs/inode.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2504,7 +2504,7 @@ noinline int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans,
		struct btrfs_path *path;
		struct btrfs_key key;
		struct btrfs_key found_key;
		u32 found_type;
		u32 found_type = (u8)-1;
		struct extent_buffer *leaf;
		struct btrfs_file_extent_item *fi;
		u64 extent_start = 0;
		@@ -2691,6 +2691,8 @@ next:
		if (pending_del_nr)
		goto del_pending;
		btrfs_release_path(root, path);
		if (found_type == BTRFS_INODE_ITEM_KEY)
		break;
		goto search_again;
		}

		@@ -2707,6 +2709,8 @@ del_pending:
		BUG_ON(ret);
		pending_del_nr = 0;
		btrfs_release_path(root, path);
		if (found_type == BTRFS_INODE_ITEM_KEY)
		break;
		goto search_again;
		}
		}

Admin message