Commit 06b43672 authored by Jeff Layton's avatar Jeff Layton Committed by Steve French
Browse files

cifs: fix page refcount leak 



Commit 315e995c is causing OOM kills
when stress-testing a CIFS filesystem. The VFS readpages operation takes
a page reference. The older code just handed this reference off to the
page cache, but the new code takes an extra one. The simplest fix is to
put the new reference after add_to_page_cache_lru.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Acked-by: default avatarNick Piggin <npiggin@suse.de>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 67a3e12b

fs/cifs/file.c

+1 −0
Original line number Diff line number Diff line
@@ -1952,6 +1952,7 @@ static void cifs_copy_cache_pages(struct address_space *mapping, 
			bytes_read -= PAGE_CACHE_SIZE;

			continue;

		}

		page_cache_release(page);



		target = kmap_atomic(page, KM_USER0);

CRA Git | Maintained and supported by SUSTech CRA and CCSE