Commit 069a47e5 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

tty: serial: constify uart_ops structures 

Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5d9b9530

drivers/tty/serial/fsl_lpuart.c

+2 −2
Original line number Diff line number Diff line
@@ -1579,7 +1579,7 @@ static int lpuart_verify_port(struct uart_port *port, struct serial_struct *ser) 
	return ret;

}



static struct uart_ops lpuart_pops = {

static const struct uart_ops lpuart_pops = {

	.tx_empty	= lpuart_tx_empty,

	.set_mctrl	= lpuart_set_mctrl,

	.get_mctrl	= lpuart_get_mctrl,
@@ -1598,7 +1598,7 @@ static struct uart_ops lpuart_pops = { 
	.flush_buffer	= lpuart_flush_buffer,

};



static struct uart_ops lpuart32_pops = {

static const struct uart_ops lpuart32_pops = {

	.tx_empty	= lpuart32_tx_empty,

	.set_mctrl	= lpuart32_set_mctrl,

	.get_mctrl	= lpuart32_get_mctrl,

drivers/tty/serial/imx.c

+1 −1
Original line number Diff line number Diff line
@@ -1737,7 +1737,7 @@ static int imx_rs485_config(struct uart_port *port, 
	return 0;

}



static struct uart_ops imx_pops = {

static const struct uart_ops imx_pops = {

	.tx_empty	= imx_tx_empty,

	.set_mctrl	= imx_set_mctrl,

	.get_mctrl	= imx_get_mctrl,

drivers/tty/serial/max3100.c

+1 −1
Original line number Diff line number Diff line
@@ -712,7 +712,7 @@ static void max3100_break_ctl(struct uart_port *port, int break_state) 
	dev_dbg(&s->spi->dev, "%s\n", __func__);

}



static struct uart_ops max3100_ops = {

static const struct uart_ops max3100_ops = {

	.tx_empty	= max3100_tx_empty,

	.set_mctrl	= max3100_set_mctrl,

	.get_mctrl	= max3100_get_mctrl,

drivers/tty/serial/men_z135_uart.c

+1 −1
Original line number Diff line number Diff line
@@ -775,7 +775,7 @@ static int men_z135_verify_port(struct uart_port *port, 
	return -EINVAL;

}



static struct uart_ops men_z135_ops = {

static const struct uart_ops men_z135_ops = {

	.tx_empty = men_z135_tx_empty,

	.set_mctrl = men_z135_set_mctrl,

	.get_mctrl = men_z135_get_mctrl,

drivers/tty/serial/mxs-auart.c

+1 −1
Original line number Diff line number Diff line
@@ -1317,7 +1317,7 @@ static void mxs_auart_break_ctl(struct uart_port *u, int ctl) 
		mxs_clr(AUART_LINECTRL_BRK, s, REG_LINECTRL);

}



static struct uart_ops mxs_auart_ops = {

static const struct uart_ops mxs_auart_ops = {

	.tx_empty       = mxs_auart_tx_empty,

	.start_tx       = mxs_auart_start_tx,

	.stop_tx	= mxs_auart_stop_tx,

CRA Git | Maintained and supported by SUSTech CRA and CCSE