mtd: rawnand: sunxi: Stop using nand_release() (068d86ec) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-55-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/sunxi_nand.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -2039,13 +2039,18 @@ static int sunxi_nand_chips_init(struct device dev, struct sunxi_nfc nfc)
		static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc)
		{
		struct sunxi_nand_chip *sunxi_nand;
		struct nand_chip *chip;
		int ret;

		while (!list_empty(&nfc->chips)) {
		sunxi_nand = list_first_entry(&nfc->chips,
		struct sunxi_nand_chip,
		node);
		nand_release(&sunxi_nand->nand);
		sunxi_nand_ecc_cleanup(&sunxi_nand->nand.ecc);
		chip = &sunxi_nand->nand;
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		sunxi_nand_ecc_cleanup(&chip->ecc);
		list_del(&sunxi_nand->node);
		}
		}

Admin message