Commit 068ce415 authored Jul 08, 2012 by Julia Lawall Committed by Pekka Enberg Jul 09, 2012

slub: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  The patch replaces s->name by al->name, which is
referenced nearby.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/

).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Pekka Enberg <penberg@kernel.org>

parent 4b57ad93

mm/slub.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5405,7 +5405,7 @@ static int __init slab_sysfs_init(void)
		err = sysfs_slab_alias(al->s, al->name);
		if (err)
		printk(KERN_ERR "SLUB: Unable to add boot slab alias"
		" %s to sysfs\n", s->name);
		" %s to sysfs\n", al->name);
		kfree(al);
		}

Admin message