Commit 068b88cc authored Oct 04, 2018 by Jakub Sitnicki Committed by David S. Miller Oct 05, 2018

socket: Tighten no-error check in bind()



move_addr_to_kernel() returns only negative values on error, or zero on
success. Rewrite the error check to an idiomatic form to avoid confusing
the reader.

Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9a694c1d

net/socket.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1475,7 +1475,7 @@ int __sys_bind(int fd, struct sockaddr __user *umyaddr, int addrlen)
		sock = sockfd_lookup_light(fd, &err, &fput_needed);
		if (sock) {
		err = move_addr_to_kernel(umyaddr, addrlen, &address);
		if (err >= 0) {
		if (!err) {
		err = security_socket_bind(sock,
		(struct sockaddr *)&address,
		addrlen);

Admin message