Commit 0668b472 authored Aug 31, 2006 by Wei Dong Committed by David S. Miller Aug 31, 2006

[IPV4]: Fix SNMPv2 "ipFragFails" counter error



  When I tested Linux kernel 2.6.17.7 about statistics
"ipFragFails",found that this counter couldn't increase correctly. The
criteria is RFC2011:
RFC2011
  ipFragFails OBJECT-TYPE
    SYNTAX      Counter32
    MAX-ACCESS  read-only
    STATUS      current
    DESCRIPTION
            "The number of IP datagrams that have been discarded because
            they needed to be fragmented at this entity but could not
            be, e.g., because their Don't Fragment flag was set."
    ::= { ip 18 }

When I send big IP packet to a router with DF bit set to 1 which need to
be fragmented, and router just sends an ICMP error message
ICMP_FRAG_NEEDED but no increments for this counter(in the function
ip_fragment).

Signed-off-by: Wei Dong <weid@nanjing-fnst.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5991c844

net/ipv4/ip_output.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -440,6 +440,7 @@ int ip_fragment(struct sk_buff skb, int (output)(struct sk_buff*))
		iph = skb->nh.iph;

		if (unlikely((iph->frag_off & htons(IP_DF)) && !skb->local_df)) {
		IP_INC_STATS(IPSTATS_MIB_FRAGFAILS);
		icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
		htonl(dst_mtu(&rt->u.dst)));
		kfree_skb(skb);

Admin message