Commit 065ea0a7 authored Jun 20, 2017 by Arnd Bergmann Committed by Greg Kroah-Hartman Jul 30, 2017

tty: improve tty_insert_flip_char() slow path



While working on improving the fast path of tty_insert_flip_char(),
I noticed that by calling tty_buffer_request_room(), we needlessly
move to the separate flag buffer mode for the tty, even when all
characters use TTY_NORMAL as the flag.

This changes the code to call __tty_buffer_request_room() with the
correct flag, which will then allocate a regular buffer when it rounds
out of space but no special flags have been used. I'm guessing that
this is the behavior that Peter Hurley intended when he introduced
the compacted flip buffers.

Fixes: acc0f67f ("tty: Halve flip buffer GFP_ATOMIC memory consumption")
Cc: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 979990c6

drivers/tty/tty_buffer.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -375,9 +375,10 @@ int __tty_insert_flip_char(struct tty_port *port, unsigned char ch, char flag)
		struct tty_buffer *tb = port->buf.tail;
		int flags = (flag == TTY_NORMAL) ? TTYB_NORMAL : 0;

		if (!tty_buffer_request_room(port, 1))
		if (!__tty_buffer_request_room(port, 1, flags))
		return 0;

		if (~tb->flags & TTYB_NORMAL)
		*flag_buf_ptr(tb, tb->used) = flag;
		*char_buf_ptr(tb, tb->used++) = ch;

Admin message