Commit 064f0e93 authored Oct 13, 2017 by Zhen Lei Committed by Linus Torvalds Oct 13, 2017

mm: only display online cpus of the numa node

When I execute numactl -H (which reads /sys/devices/system/node/nodeX/cpumap
and displays cpumask_of_node for each node), I get different result
on X86 and arm64.  For each numa node, the former only displayed online
CPUs, and the latter displayed all possible CPUs.  Unfortunately, both
Linux documentation and numactl manual have not described it clear.

I sent a mail to ask for help, and Michal Hocko replied that he
preferred to print online cpus because it doesn't really make much sense
to bind anything on offline nodes.

Will said:
 "I suspect the vast majority (if not all) code that reads this file was
  developed for x86, so having the same behaviour for arm64 sounds like
  something we should do ASAP before people try to special case with
  things like #ifdef __aarch64__. I'd rather have this in 4.14 if
  possible."

Link: http://lkml.kernel.org/r/1506678805-15392-2-git-send-email-thunder.leizhen@huawei.com


Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tianhong Ding <dingtianhong@huawei.com>
Cc: Hanjun Guo <guohanjun@huawei.com>
Cc: Libin <huawei.libin@huawei.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent af0db981

drivers/base/node.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -27,13 +27,21 @@ static struct bus_type node_subsys = {

		static ssize_t node_read_cpumap(struct device dev, bool list, char buf)
		{
		ssize_t n;
		cpumask_var_t mask;
		struct node *node_dev = to_node(dev);
		const struct cpumask *mask = cpumask_of_node(node_dev->dev.id);

		/* 2008/04/07: buf currently PAGE_SIZE, need 9 chars per 32 bits. */
		BUILD_BUG_ON((NR_CPUS/32 * 9) > (PAGE_SIZE-1));

		return cpumap_print_to_pagebuf(list, buf, mask);
		if (!alloc_cpumask_var(&mask, GFP_KERNEL))
		return 0;

		cpumask_and(mask, cpumask_of_node(node_dev->dev.id), cpu_online_mask);
		n = cpumap_print_to_pagebuf(list, buf, mask);
		free_cpumask_var(mask);

		return n;
		}

		static inline ssize_t node_read_cpumask(struct device *dev,

Admin message