Commit 062d3f95 authored Jul 23, 2020 by Chris Wilson Committed by Ingo Molnar Jul 24, 2020

sched: Warn if garbage is passed to default_wake_function()



Since the default_wake_function() passes its flags onto
try_to_wake_up(), warn if those flags collide with internal values.

Given that the supplied flags are garbage, no repair can be done but at
least alert the user to the damage they are causing.

In the belief that these errors should be picked up during testing, the
warning is only compiled in under CONFIG_SCHED_DEBUG.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: https://lore.kernel.org/r/20200723201042.18861-1-chris@chris-wilson.co.uk

parent d136122f

kernel/sched/core.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -4485,6 +4485,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void)
		int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags,
		void *key)
		{
		WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC);
		return try_to_wake_up(curr->private, mode, wake_flags);
		}
		EXPORT_SYMBOL(default_wake_function);

Admin message