Commit 062a33b1 authored Jan 16, 2020 by Alex Marginean Committed by David S. Miller Jan 17, 2020

net: dsa: felix: Set USXGMII link based on BMSR, not LPA



At least some PHYs (AQR412) don't advertise copper-side link status
during system side AN.

So remove this duplicate assignment to pcs->link and rely on the
previous one for link state: the local indication from the MAC PCS.

Fixes: bdeced75 ("net: dsa: felix: Add PCS operations for PHYLINK")
Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1d0ee02b

drivers/net/dsa/ocelot/felix_vsc9959.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -892,7 +892,6 @@ static void vsc9959_pcs_link_state_usxgmii(struct phy_device *pcs,
		break;
		}

		pcs->link = USXGMII_LPA_LNKS(lpa);
		if (USXGMII_LPA_DUPLEX(lpa))
		pcs->duplex = DUPLEX_FULL;
		else

Admin message