Commit 062795fc authored Oct 08, 2019 by Christian Borntraeger Committed by Vasily Gorbik Oct 11, 2019

s390/uaccess: avoid (false positive) compiler warnings



Depending on inlining decisions by the compiler, __get/put_user_fn
might become out of line. Then the compiler is no longer able to tell
that size can only be 1,2,4 or 8 due to the check in __get/put_user
resulting in false positives like

./arch/s390/include/asm/uaccess.h: In function ‘__put_user_fn’:
./arch/s390/include/asm/uaccess.h:113:9: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  113 |  return rc;
      |         ^~
./arch/s390/include/asm/uaccess.h: In function ‘__get_user_fn’:
./arch/s390/include/asm/uaccess.h:143:9: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  143 |  return rc;
      |         ^~

These functions are supposed to be always inlined. Mark it as such.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent 05668e1d

arch/s390/include/asm/uaccess.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -83,7 +83,7 @@ raw_copy_to_user(void __user to, const void from, unsigned long n);
		__rc; \
		})

		static inline int __put_user_fn(void x, void __user ptr, unsigned long size)
		static __always_inline int __put_user_fn(void x, void __user ptr, unsigned long size)
		{
		unsigned long spec = 0x010000UL;
		int rc;
		@@ -113,7 +113,7 @@ static inline int __put_user_fn(void x, void __user ptr, unsigned long size)
		return rc;
		}

		static inline int __get_user_fn(void x, const void __user ptr, unsigned long size)
		static __always_inline int __get_user_fn(void x, const void __user ptr, unsigned long size)
		{
		unsigned long spec = 0x01UL;
		int rc;

Admin message