Commit 062261be authored Aug 18, 2014 by Andreea-Cristina Bernat Committed by Jens Axboe Nov 04, 2014

nvme: Replace rcu_assign_pointer() with RCU_INIT_POINTER()



The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 59055356

drivers/block/nvme-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1230,7 +1230,7 @@ static void nvme_free_queues(struct nvme_dev *dev, int lowest)

		for (i = dev->queue_count - 1; i >= lowest; i--) {
		nvmeq = raw_nvmeq(dev, i);
		rcu_assign_pointer(dev->queues[i], NULL);
		RCU_INIT_POINTER(dev->queues[i], NULL);
		llist_add(&nvmeq->node, &q_list);
		dev->queue_count--;
		}

Admin message