Commit 060d20d3 authored Oct 19, 2009 by Uwe Kleine-König Committed by Sascha Hauer Nov 14, 2009

imx/gpio: Use handle_level_irq



According to Russell King handle_edge_irq is only useful for "edge-based
inputs where the controller does not remember transitions with the input
masked."

So using handle_edge_irq unconditionally for both edge and level irqs is
wrong.  Testing showed that the controller does remember transitions
while the interrupt is masked.  So use handle_level_irq unconditionally.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

parent f4f8bda2

arch/arm/plat-mxc/gpio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -282,7 +282,7 @@ int __init mxc_gpio_init(struct mxc_gpio_port *port, int cnt)
		for (j = port[i].virtual_irq_start;
		j < port[i].virtual_irq_start + 32; j++) {
		set_irq_chip(j, &gpio_irq_chip);
		set_irq_handler(j, handle_edge_irq);
		set_irq_handler(j, handle_level_irq);
		set_irq_flags(j, IRQF_VALID);
		}

Admin message