Commit 05f2f274 authored Jan 07, 2011 by Tony Luck

[IA64] Avoid array overflow if there are too many cpus in SRAT table



acpi_numa_init() has to parse the whole SRAT table, even if the
kernel wants to limit the number of cpus it will use (because the
ones it is going to use may be described by entries at the end of
the SRAT table).  Avoid overflowing the node_cpuid array.

Reported-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent e7d28253

arch/ia64/kernel/acpi.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -477,6 +477,12 @@ acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa)
		if (!(pa->flags & ACPI_SRAT_CPU_ENABLED))
		return;

		if (srat_num_cpus >= ARRAY_SIZE(node_cpuid)) {
		printk_once(KERN_WARNING
		"node_cpuid[%d] is too small, may not be able to use all cpus\n",
		ARRAY_SIZE(node_cpuid));
		return;
		}
		pxm = get_processor_proximity_domain(pa);

		/* record this node in proximity bitmap */

Admin message