Commit 05ed160e authored Sep 13, 2010 by Masami Hiramatsu Committed by Ingo Molnar Sep 13, 2010

kprobes: Fix Kconfig dependency



Fix Kconfig dependency among Kprobes, optprobe and kallsyms.

Kprobes uses kallsyms_lookup for finding target function and
checking instruction boundary, thus CONFIG_KPROBES should select
CONFIG_KALLSYMS.

Optprobe is an optional feature which is supported on x86 arch,
and it also uses kallsyms_lookup for checking instructions in
the target function. Since KALLSYMS_ALL just adds symbols of
kernel variables, it doesn't need to select KALLSYMS_ALL.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com&gt;,>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: akpm <akpm@linux-foundation.org>
LKML-Reference: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 49553c2e

arch/Kconfig

+2 −2

Original line number	Diff line number	Diff line
		@@ -32,8 +32,9 @@ config HAVE_OPROFILE

		config KPROBES
		bool "Kprobes"
		depends on KALLSYMS && MODULES
		depends on MODULES
		depends on HAVE_KPROBES
		select KALLSYMS
		help
		Kprobes allows you to trap at almost any kernel address and
		execute a callback function. register_kprobe() establishes
		@@ -45,7 +46,6 @@ config OPTPROBES
		def_bool y
		depends on KPROBES && HAVE_OPTPROBES
		depends on !PREEMPT
		select KALLSYMS_ALL

		config HAVE_EFFICIENT_UNALIGNED_ACCESS
		bool

Admin message