Commit 05e13bb5 authored May 12, 2018 by Jean Delvare Committed by Christoph Hellwig May 12, 2018

swiotlb: silent unwanted warning "buffer is full"

If DMA_ATTR_NO_WARN is passed to swiotlb_alloc_buffer(), it should be
passed further down to swiotlb_tbl_map_single(). Otherwise we escape
half of the warnings but still log the other half.

This is one of the multiple causes of spurious warnings reported at:
https://bugs.freedesktop.org/show_bug.cgi?id=104082



Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 0176adb0 ("swiotlb: refactor coherent buffer allocation")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Michel Dänzer <michel@daenzer.net>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: stable@vger.kernel.org # v4.16

parent 75bc37fe

lib/swiotlb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -714,7 +714,7 @@ swiotlb_alloc_buffer(struct device dev, size_t size, dma_addr_t dma_handle,

		phys_addr = swiotlb_tbl_map_single(dev,
		__phys_to_dma(dev, io_tlb_start),
		0, size, DMA_FROM_DEVICE, 0);
		0, size, DMA_FROM_DEVICE, attrs);
		if (phys_addr == SWIOTLB_MAP_ERROR)
		goto out_warn;

Admin message