Commit 05aa3450 authored Nov 05, 2007 by Christoph Lameter Committed by Linus Torvalds Nov 05, 2007

SLUB: Fix memory leak by not reusing cpu_slab



Fix the memory leak that may occur when we attempt to reuse a cpu_slab
that was allocated while we reenabled interrupts in order to be able to
grow a slab cache.

The per cpu freelist may contain objects and in that situation we may
overwrite the per cpu freelist pointer loosing objects.  This only
occurs if we find that the concurrently allocated slab fits our
allocation needs.

If we simply always deactivate the slab then the freelist will be
properly reintegrated and the memory leak will go away.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent aac9e28d

mm/slub.c

+1 −19

Original line number	Diff line number	Diff line
		@@ -1511,26 +1511,8 @@ new_slab:

		if (new) {
		c = get_cpu_slab(s, smp_processor_id());
		if (c->page) {
		/*
		* Someone else populated the cpu_slab while we
		* enabled interrupts, or we have gotten scheduled
		* on another cpu. The page may not be on the
		* requested node even if __GFP_THISNODE was
		* specified. So we need to recheck.
		*/
		if (node_match(c, node)) {
		/*
		* Current cpuslab is acceptable and we
		* want the current one since its cache hot
		*/
		discard_slab(s, new);
		slab_lock(c->page);
		goto load_freelist;
		}
		/* New slab does not fit our expectations */
		if (c->page)
		flush_slab(s, c);
		}
		slab_lock(new);
		SetSlabFrozen(new);
		c->page = new;

Admin message