Commit 058f8c3f authored May 27, 2017 by Sricharan R Committed by Joerg Roedel May 30, 2017

ACPI/IORT: Ignore all errors except EPROBE_DEFER



While deferring the probe of IOMMU masters, xlate and
add_device callbacks called from iort_iommu_configure
can pass back error values like -ENODEV, which means
the IOMMU cannot be connected with that master for real
reasons. Before the IOMMU probe deferral, all such errors
were ignored. Now all those errors are propagated back,
killing the master's probe for such errors. Instead ignore
all the errors except EPROBE_DEFER, which is the only one
of concern and let the master work without IOMMU, thus
restoring the old behavior. Also make explicit that
acpi_dma_configure handles only -EPROBE_DEFER from
iort_iommu_configure.

Fixes: 5a1bb638 ("drivers: acpi: Handle IOMMU lookup failure with deferred probing or error")
Signed-off-by: Sricharan R <sricharan@codeaurora.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent a37b19a3

drivers/acpi/arm64/iort.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -782,6 +782,12 @@ const struct iommu_ops iort_iommu_configure(struct device dev)
		if (err)
		ops = ERR_PTR(err);

		/* Ignore all other errors apart from EPROBE_DEFER */
		if (IS_ERR(ops) && (PTR_ERR(ops) != -EPROBE_DEFER)) {
		dev_dbg(dev, "Adding to IOMMU failed: %ld\n", PTR_ERR(ops));
		ops = NULL;
		}

		return ops;
		}

drivers/acpi/scan.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1371,8 +1371,8 @@ int acpi_dma_configure(struct device *dev, enum dev_dma_attr attr)
		iort_set_dma_mask(dev);

		iommu = iort_iommu_configure(dev);
		if (IS_ERR(iommu))
		return PTR_ERR(iommu);
		if (IS_ERR(iommu) && PTR_ERR(iommu) == -EPROBE_DEFER)
		return -EPROBE_DEFER;

		size = max(dev->coherent_dma_mask, dev->coherent_dma_mask + 1);
		/*

Admin message