Commit 058236ee authored Nov 26, 2020 by Yang Yingliang Committed by Will Deacon Nov 26, 2020

iommu: return error code when it can't get group



Although iommu_group_get() in iommu_probe_device() will always succeed
thanks to __iommu_probe_device() creating the group if it's not present,
it's still worth initialising 'ret' to -ENODEV in case this path is
reachable in the future.

For now, this patch results in no functional change.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20201126133825.3643852-1-yangyingliang@huawei.com


Signed-off-by: Will Deacon <will@kernel.org>

parent 6243f572

drivers/iommu/iommu.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -253,8 +253,10 @@ int iommu_probe_device(struct device *dev)
		goto err_out;

		group = iommu_group_get(dev);
		if (!group)
		if (!group) {
		ret = -ENODEV;
		goto err_release;
		}

		/*
		* Try to allocate a default domain - needs support from the

Admin message