Commit 0580b762 authored Mar 06, 2017 by Tejun Heo

libata: drop WARN from protocol error in ata_sff_qc_issue()



ata_sff_qc_issue() expects upper layers to never issue commands on a
command protocol that it doesn't implement.  While the assumption
holds fine with the usual IO path, nothing filters based on the
command protocol in the passthrough path (which was added later),
allowing the warning to be tripped with a passthrough command with the
right (well, wrong) protocol.

Failing with AC_ERR_SYSTEM is the right thing to do anyway.  Remove
the unnecessary WARN.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Link: http://lkml.kernel.org/r/CACT4Y+bXkvevNZU8uP6X0QVqsj6wNoUA_1exfTSOzc+SmUtMOA@mail.gmail.com


Signed-off-by: Tejun Heo <tj@kernel.org>

parent d85fc67d

drivers/ata/libata-sff.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1482,7 +1482,6 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc)
		break;

		default:
		WARN_ON_ONCE(1);
		return AC_ERR_SYSTEM;
		}

Admin message