Commit 055b185a authored Feb 14, 2020 by Jules Irenge Committed by Greg Kroah-Hartman Feb 17, 2020

xhci: Add missing annotation for xhci_enter_test_mode

Sparse reports a warning at xhci_enter_test_mode()

warning: context imbalance in xhci_enter_test_mode - unexpected unlock

The root cause is the missing annotation at xhci_enter_test_mode()
Add the missing __must_hold(&xhci->lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20200214204741.94112-24-jbi.octave@gmail.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dce174e0

drivers/usb/host/xhci-hub.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -609,6 +609,7 @@ static void xhci_port_set_test_mode(struct xhci_hcd *xhci,

		static int xhci_enter_test_mode(struct xhci_hcd *xhci,
		u16 test_mode, u16 wIndex, unsigned long *flags)
		__must_hold(&xhci->lock)
		{
		int i, retval;