tipc: fix uninitialized value for broadcast retransmission (05572271) · Commits · 戴 / test

When sending broadcast message on high load system, there are a lot of unnecessary packets restranmission. That issue was caused by missing in initial criteria for retransmission. To prevent this happen, just initialize this criteria for retransmission in next 10 milliseconds. Fixes: ("tipc: improve broadcast retransmission algorithm") Acked-by:

Ying Xue <ying.xue@windriver.com> Acked-by:

Jon Maloy <jon.maloy@ericsson.com> Signed-off-by:

Hoang Le <hoang.h.le@dektech.com.au> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/tipc/link.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -967,6 +967,10 @@ int tipc_link_xmit(struct tipc_link l, struct sk_buff_head list,
		}
		__skb_dequeue(list);
		__skb_queue_tail(transmq, skb);
		/* next retransmit attempt */
		if (link_is_bc_sndlink(l))
		TIPC_SKB_CB(skb)->nxt_retr =
		jiffies + TIPC_BC_RETR_LIM;
		__skb_queue_tail(xmitq, _skb);
		TIPC_SKB_CB(skb)->ackers = l->ackers;
		l->rcv_unacked = 0;
		@@ -1014,6 +1018,10 @@ static void tipc_link_advance_backlog(struct tipc_link *l,
		hdr = buf_msg(skb);
		l->backlog[msg_importance(hdr)].len--;
		__skb_queue_tail(&l->transmq, skb);
		/* next retransmit attempt */
		if (link_is_bc_sndlink(l))
		TIPC_SKB_CB(skb)->nxt_retr = jiffies + TIPC_BC_RETR_LIM;

		__skb_queue_tail(xmitq, _skb);
		TIPC_SKB_CB(skb)->ackers = l->ackers;
		msg_set_seqno(hdr, seqno);

Admin message