Commit 054814b8 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Lee Jones
Browse files

mfd: tps65912: Move regmap config into core driver 



When building with extra warnings enabled, most files including
linux/mfd/tps65912.h warn about a static variable defined in the
header:

include/linux/mfd/tps65912.h:331:35: warning: 'tps65912_regmap_config' defined but not used [-Wunused-const-variable=]

We also duplicate the data structure between the i2c and spi front-end
drivers. Moving it into the driver code avoids the warning and
the duplication.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent bb63f7d3

drivers/mfd/tps65912-core.c

+17 −0
Original line number Diff line number Diff line
@@ -77,6 +77,23 @@ static struct regmap_irq_chip tps65912_irq_chip = { 
	.init_ack_masked = true,

};



static const struct regmap_range tps65912_yes_ranges[] = {

	regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5),

};



static const struct regmap_access_table tps65912_volatile_table = {

	.yes_ranges = tps65912_yes_ranges,

	.n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges),

};



const struct regmap_config tps65912_regmap_config = {

	.reg_bits = 8,

	.val_bits = 8,

	.cache_type = REGCACHE_RBTREE,

	.volatile_table = &tps65912_volatile_table,

};

EXPORT_SYMBOL_GPL(tps65912_regmap_config);



int tps65912_device_init(struct tps65912 *tps)

{

	int ret;

include/linux/mfd/tps65912.h

+1 −15
Original line number Diff line number Diff line
@@ -319,21 +319,7 @@ struct tps65912 { 
	struct regmap_irq_chip_data *irq_data;

};



static const struct regmap_range tps65912_yes_ranges[] = {

	regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5),

};



static const struct regmap_access_table tps65912_volatile_table = {

	.yes_ranges = tps65912_yes_ranges,

	.n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges),

};



static const struct regmap_config tps65912_regmap_config = {

	.reg_bits = 8,

	.val_bits = 8,

	.cache_type = REGCACHE_RBTREE,

	.volatile_table = &tps65912_volatile_table,

};

extern const struct regmap_config tps65912_regmap_config;



int tps65912_device_init(struct tps65912 *tps);

int tps65912_device_exit(struct tps65912 *tps);

CRA Git | Maintained and supported by SUSTech CRA and CCSE