Commit 053be305 authored Jun 27, 2006 by Eric Sesterhenn Committed by Greg Kroah-Hartman Jul 12, 2006

[PATCH] USB: fix pointer dereference in drivers/usb/misc/usblcd



coverity spotted (id #185) that we still use urb, if the allocation
fails in the error path. This patch fixes this by returning directly.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent c1b45f24

drivers/usb/misc/usblcd.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -200,10 +200,8 @@ static ssize_t lcd_write(struct file file, const char __user user_buffer, siz

		/* create a urb, and a buffer for it, and copy the data to the urb */
		urb = usb_alloc_urb(0, GFP_KERNEL);
		if (!urb) {
		retval = -ENOMEM;
		goto error;
		}
		if (!urb)
		return -ENOMEM;

		buf = usb_buffer_alloc(dev->udev, count, GFP_KERNEL, &urb->transfer_dma);
		if (!buf) {

Admin message