Commit 052f7c8b authored Mar 01, 2019 by Antoine Tenart Committed by David S. Miller Mar 01, 2019

net: mvpp2: a port can be disabled even if we use the link IRQ



We had a check in the mvpp2_mac_link_down() function (called by phylink)
to avoid disabling the port when link interrupts are used. It turned out
the interrupt can still be used with the port disabled. We can thus
remove this check.

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0caa756b

drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -4738,13 +4738,6 @@ static void mvpp2_mac_link_down(struct net_device *dev, unsigned int mode,
		mvpp2_egress_disable(port);
		mvpp2_ingress_disable(port);

		/* When using link interrupts to notify phylink of a MAC state change,
		* we do not want the port to be disabled (we want to receive further
		* interrupts, to be notified when the port will have a link later).
		*/
		if (!port->has_phy)
		return;

		mvpp2_port_disable(port);
		}

Admin message