Commit 0529a46a authored Jan 25, 2016 by Alexandre Courbot Committed by Ben Skeggs Mar 14, 2016

drm/nouveau/device: call nvkm_device_fini if nvkm_device_init fails



nvkm_device_fini is never called if a failure occurs in
nvkm_device_init, even when unloading the module. This can lead to a
resources leak (one example is the Tegra interrupt which would never be
freed in that case). Fix this by calling nvkm_device_fini in
nvkm_device_init's failure path.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 33bcb4c3

drivers/gpu/drm/nouveau/nvkm/engine/device/base.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2261,6 +2261,8 @@ fail_subdev:
		} while (--i >= 0);

		fail:
		nvkm_device_fini(device, false);

		nvdev_error(device, "init failed with %d\n", ret);
		return ret;
		}

Admin message