Commit 05177f17 authored May 02, 2008 by Alan Cox Committed by Jeff Garzik May 06, 2008

pata_atiixp: Don't disable



A couple of distributions (Fedora, Ubuntu) were having weird problems with the
ATI IXP series PATA controllers being reported as simplex.  At the heart of
the problem is that both distros ignored the recommendations to load pata_acpi
and ata_generic *AFTER* specific host drivers.

The underlying cause however is that if you D3 and then D0 an ATI IXP it
helpfully throws away some configuration and won't let you rewrite it.

Add checks to ata_generic and pata_acpi to pin ATIIXP devices.  Possibly the
real answer here is to quirk them and pin them, but right now we can't do that
before they've been pcim_enable()'d by a driver.

I'm indebted to David Gero for this.  His bug report not only reported the
problem but identified the cause correctly and he had tested the right values
to prove what was going on

[If you backport this for 2.6.24 you will need to pull in the 2.6.25
removal of the bogus WARN_ON() in pcim_enagle]

Signed-off-by: Alan Cox <alan@redhat.com>
Tested-by: David Gero <davidg@havidave.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 22bfc6d5

drivers/ata/ata_generic.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -152,6 +152,12 @@ static int ata_generic_init_one(struct pci_dev *dev, const struct pci_device_id
		if (dev->vendor == PCI_VENDOR_ID_AL)
		ata_pci_bmdma_clear_simplex(dev);

		if (dev->vendor == PCI_VENDOR_ID_ATI) {
		int rc = pcim_enable_device(dev);
		if (rc < 0)
		return rc;
		pcim_pin_device(dev);
		}
		return ata_pci_sff_init_one(dev, ppi, &generic_sht, NULL);
		}

drivers/ata/pata_acpi.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -259,6 +259,12 @@ static int pacpi_init_one (struct pci_dev pdev, const struct pci_device_id id)
		.port_ops = &pacpi_ops,
		};
		const struct ata_port_info *ppi[] = { &info, NULL };
		if (pdev->vendor == PCI_VENDOR_ID_ATI) {
		int rc = pcim_enable_device(pdev);
		if (rc < 0)
		return rc;
		pcim_pin_device(pdev);
		}
		return ata_pci_sff_init_one(pdev, ppi, &pacpi_sht, NULL);
		}

Admin message