Commit 0515760f authored Aug 31, 2017 by Christophe Jaillet Committed by Mark Brown Aug 31, 2017

ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'



If 'clk_prepare_enable()' fails, we must release some resources before
returning. Add a new label in the existing error handling path and 'goto'
there.

Fixes: 260ea95c ("ASoC: atmel: ac97c: Handle return value of clk_prepare_enable.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent acd617a4

sound/atmel/ac97c.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -785,7 +785,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
		}
		retval = clk_prepare_enable(pclk);
		if (retval)
		return retval;
		goto err_prepare_enable;

		retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1,
		SNDRV_DEFAULT_STR1, THIS_MODULE,
		@@ -881,6 +881,7 @@ err_request_irq:
		snd_card_free(card);
		err_snd_card_new:
		clk_disable_unprepare(pclk);
		err_prepare_enable:
		clk_put(pclk);
		return retval;
		}

Admin message