Commit 04fd4cb0 authored Sep 19, 2016 by Kai-Heng Feng Committed by Jiri Kosina Sep 22, 2016

HID: alps: fix stick device not working after resume



The stick device does not work after resume, add U1_SP_ABS_MODE flag can
make the device work after resume.

This has been discovered by pure guesswork, based on how the existing code uses
U1_TP_ABS_MODE flag on both initialization and resume.

I also tested the the patch on an ALPS touchpad without stick device, did not
notice any side effect on suspend/resume, so I made the U1_SP_ABS_MODE flag
mandatory.

[jkosina@suse.cz: made changelog more verbose]
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 7ee2eaa3

drivers/hid/hid-alps.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -245,13 +245,13 @@ static int alps_raw_event(struct hid_device *hdev,
		static int alps_post_reset(struct hid_device *hdev)
		{
		return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1,
		NULL, U1_TP_ABS_MODE, false);
		NULL, U1_TP_ABS_MODE \| U1_SP_ABS_MODE, false);
		}

		static int alps_post_resume(struct hid_device *hdev)
		{
		return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1,
		NULL, U1_TP_ABS_MODE, false);
		NULL, U1_TP_ABS_MODE \| U1_SP_ABS_MODE, false);
		}
		#endif /* CONFIG_PM */

Admin message