Commit 04eb94d5 authored Aug 18, 2019 by Nishka Dasgupta Committed by Greg Kroah-Hartman Aug 18, 2019

slimbus: qcom-ngd-ctrl: Add of_node_put() before return



Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20190818093902.29993-2-srinivas.kandagatla@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 672a749b

drivers/slimbus/qcom-ngd-ctrl.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1338,12 +1338,15 @@ static int of_qcom_slim_ngd_register(struct device *parent,
		continue;

		ngd = kzalloc(sizeof(*ngd), GFP_KERNEL);
		if (!ngd)
		if (!ngd) {
		of_node_put(node);
		return -ENOMEM;
		}

		ngd->pdev = platform_device_alloc(QCOM_SLIM_NGD_DRV_NAME, id);
		if (!ngd->pdev) {
		kfree(ngd);
		of_node_put(node);
		return -ENOMEM;
		}
		ngd->id = id;

Admin message