Commit 04db1580 authored Dec 30, 2019 by Xiyu Yang Committed by Jason Gunthorpe Jan 03, 2020

RDMA/i40iw: fix a potential NULL pointer dereference

A NULL pointer can be returned by in_dev_get(). Thus add a corresponding
check so that a NULL pointer dereference will be avoided at this place.

Fixes: 8e06af71 ("i40iw: add main, hdr, status")
Link: https://lore.kernel.org/r/1577672668-46499-1-git-send-email-xiyuyang19@fudan.edu.cn


Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 6ca18d89

drivers/infiniband/hw/i40iw/i40iw_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1225,6 +1225,8 @@ static void i40iw_add_ipv4_addr(struct i40iw_device *iwdev)
		const struct in_ifaddr *ifa;

		idev = in_dev_get(dev);
		if (!idev)
		continue;
		in_dev_for_each_ifa_rtnl(ifa, idev) {
		i40iw_debug(&iwdev->sc_dev, I40IW_DEBUG_CM,
		"IP=%pI4, vlan_id=%d, MAC=%pM\n", &ifa->ifa_address,

Admin message