scsi: lpfc: Fix memory leak in abnormal exit path from lpfc_eq_create (04d210c9) · Commits · 戴 / test

eq create is leaking mailbox memory if it encounters an error. rework error path to free the memory. Signed-off-by:

drivers/scsi/lpfc/lpfc_sli.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -14641,8 +14641,10 @@ lpfc_eq_create(struct lpfc_hba phba, struct lpfc_queue eq, uint32_t imax)
		lpfc_printf_log(phba, KERN_ERR, LOG_SLI,
		"0360 Unsupported EQ count. (%d)\n",
		eq->entry_count);
		if (eq->entry_count < 256)
		return -EINVAL;
		if (eq->entry_count < 256) {
		status = -EINVAL;
		goto out;
		}
		/* fall through - otherwise default to smallest count */
		case 256:
		bf_set(lpfc_eq_context_count, &eq_create->u.request.context,
		@@ -14694,7 +14696,7 @@ lpfc_eq_create(struct lpfc_hba phba, struct lpfc_queue eq, uint32_t imax)
		eq->host_index = 0;
		eq->notify_interval = LPFC_EQ_NOTIFY_INTRVL;
		eq->max_proc_limit = LPFC_EQ_MAX_PROC_LIMIT;

		out:
		mempool_free(mbox, phba->mbox_mem_pool);
		return status;
		}