Commit 04a85d12 authored Jun 18, 2009 by Sonny Rao Committed by Benjamin Herrenschmidt Jun 26, 2009

powerpc/BSR: Fix BSR to allow mmap of small BSR on 64k kernel



On Mon, Nov 17, 2008 at 01:26:13AM -0600, Sonny Rao wrote:
> On Fri, Nov 07, 2008 at 04:28:29PM +1100, Paul Mackerras wrote:
> > Sonny Rao writes:
> >
> > > Fix the BSR driver to allow small BSR devices, which are limited to a
> > > single 4k space, on a 64k page kernel.  Previously the driver would
> > > reject the mmap since the size was smaller than PAGESIZE (or because
> > > the size was greater than the size of the device).  Now, we check for
> > > this case use remap_4k_pfn(). Also, take out code to set vm_flags,
> > > as the remap_pfn functions will do this for us.
> >
> > Thanks.
> >
> > Do we know that the BSR size will always be 4k if it's not a multiple
> > of 64k?  Is it possible that we could get 8k, 16k or 32k or BSRs?
> > If it is possible, what does the user need to be able to do?  Do they
> > just want to map 4k, or might then want to map the whole thing?
>
>
> Hi Paul, I took a look at changing the driver to reject a request for
> mapping more than a single 4k page, however the only indication we get
> of the requested size in the mmap function is the vma size, and this
> is always one page at minimum.  So, it's not possible to determine if
> the user wants one 4k page or more.  As I noted in my first response,
> there is only one case where this is even possible and I don't think
> it is a significant concern.
>
> I did notice that I left out the check to see if the user is trying to
> map more than the device length, so I fixed that.  Here's the revised
> patch.

Alright, I've reworked this now so that if we get one of these cases
where there's a bsr that's > 4k and < 64k on a 64k kernel we'll only
advertise that it is a 4k BSR to userspace.  I think this is the best
solution since user programs are only supposed to look at sysfs to
determine how much can be mapped, and libbsr does this as well.

Please consider for 2.6.31 as a fix, thanks.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

parent e4031d52

drivers/char/bsr.c

+19 −6

Original line number	Diff line number	Diff line
		@@ -27,6 +27,7 @@
		#include <linux/cdev.h>
		#include <linux/list.h>
		#include <linux/mm.h>
		#include <asm/pgtable.h>
		#include <asm/io.h>

		/*
		@@ -118,15 +119,22 @@ static int bsr_mmap(struct file filp, struct vm_area_struct vma)
		{
		unsigned long size = vma->vm_end - vma->vm_start;
		struct bsr_dev *dev = filp->private_data;
		int ret;

		if (size > dev->bsr_len \|\| (size & (PAGE_SIZE-1)))
		return -EINVAL;

		vma->vm_flags \|= (VM_IO \| VM_DONTEXPAND);
		vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);

		if (io_remap_pfn_range(vma, vma->vm_start, dev->bsr_addr >> PAGE_SHIFT,
		size, vma->vm_page_prot))
		/* check for the case of a small BSR device and map one 4k page for it*/
		if (dev->bsr_len < PAGE_SIZE && size == PAGE_SIZE)
		ret = remap_4k_pfn(vma, vma->vm_start, dev->bsr_addr >> 12,
		vma->vm_page_prot);
		else if (size <= dev->bsr_len)
		ret = io_remap_pfn_range(vma, vma->vm_start,
		dev->bsr_addr >> PAGE_SHIFT,
		size, vma->vm_page_prot);
		else
		return -EINVAL;

		if (ret)
		return -EAGAIN;

		return 0;
		@@ -206,6 +214,11 @@ static int bsr_add_node(struct device_node *bn)
		cur->bsr_stride = bsr_stride[i];
		cur->bsr_dev = MKDEV(bsr_major, i + total_bsr_devs);

		/* if we have a bsr_len of > 4k and less then PAGE_SIZE (64k pages) */
		/* we can only map 4k of it, so only advertise the 4k in sysfs */
		if (cur->bsr_len > 4096 && cur->bsr_len < PAGE_SIZE)
		cur->bsr_len = 4096;

		switch(cur->bsr_bytes) {
		case 8:
		cur->bsr_type = BSR_8;

Admin message