Commit 04a0551c authored Aug 15, 2008 by Herbert Xu Committed by David S. Miller Aug 15, 2008

loopback: Drop obsolete ip_summed setting



Now that the network stack can handle inbound packets with partial
checksums, we should no longer clobber the ip_summed field in the
loopback driver.  This is because CHECKSUM_UNNECESSARY implies that
the checksum field is actually valid which is not true for loopback
packets since it's only partial (and thus complemented).

This allows packets from lo to then be SNATed to an external source
while still preserving the checksum's validity.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6f85a124

drivers/net/loopback.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -75,9 +75,6 @@ static int loopback_xmit(struct sk_buff skb, struct net_device dev)
		skb_orphan(skb);

		skb->protocol = eth_type_trans(skb,dev);
		#ifndef LOOPBACK_MUST_CHECKSUM
		skb->ip_summed = CHECKSUM_UNNECESSARY;
		#endif

		#ifdef LOOPBACK_TSO
		if (skb_is_gso(skb)) {

Admin message