Fix VMI relocation processing logic error (0492c371) · Commits · 戴 / test

Fix logic error in VMI relocation processing. NOPs would always cause a BUG_ON to fire because the != RELOCATION_NONE in the first if clause precluding the == VMI_RELOCATION_NOP in the second clause. Make these direct equality tests and just warn for unsupported relocation types (which should never happen), falling back to native in that case. Thanks to Anthony Liguori for noting this! Signed-off-by:

Zachary Amsden <zach@vmware.com> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

arch/i386/kernel/vmi.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -712,11 +712,14 @@ static void *vmi_get_function(int vmicall)
		do { \
		reloc = call_vrom_long_func(vmi_rom, get_reloc, \
		VMI_CALL_##vmicall); \
		if (rel->type != VMI_RELOCATION_NONE) { \
		BUG_ON(rel->type != VMI_RELOCATION_CALL_REL); \
		if (rel->type == VMI_RELOCATION_CALL_REL) \
		paravirt_ops.opname = (void *)rel->eip; \
		} else if (rel->type == VMI_RELOCATION_NOP) \
		else if (rel->type == VMI_RELOCATION_NOP) \
		paravirt_ops.opname = (void *)vmi_nop; \
		else if (rel->type != VMI_RELOCATION_NONE) \
		printk(KERN_WARNING "VMI: Unknown relocation " \
		"type %d for " #vmicall"\n",\
		rel->type); \
		} while (0)

		/*

Admin message