Commit 0474d5d9 authored by Nadav Amit's avatar Nadav Amit Committed by Ingo Molnar
Browse files

x86/extable: Macrofy inline assembly code to work around GCC inlining bugs 



As described in:

  77b0bf55: ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs")

GCC's inlining heuristics are broken with common asm() patterns used in
kernel code, resulting in the effective disabling of inlining.

The workaround is to set an assembly macro and call it from the inline
assembly block - which is also a minor cleanup for the exception table
code.

Text size goes up a bit:

      text     data     bss      dec     hex  filename
  18162555 10226288 2957312 31346155 1de4deb  ./vmlinux before
  18162879 10226256 2957312 31346447 1de4f0f  ./vmlinux after (+292)

But this allows the inlining of functions such as nested_vmx_exit_reflected(),
set_segment_reg(), __copy_xstate_to_user() which is a net benefit.

Tested-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarNadav Amit <namit@vmware.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20181005202718.229565-2-namit@vmware.com
Link: https://lore.kernel.org/lkml/20181003213100.189959-9-namit@vmware.com/T/#u


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 02678a58

arch/x86/include/asm/asm.h

+20 −33
Original line number Diff line number Diff line
@@ -120,12 +120,25 @@ 
/* Exception table entry */

#ifdef __ASSEMBLY__

# define _ASM_EXTABLE_HANDLE(from, to, handler)			\

	.pushsection "__ex_table","a" ;				\

	.balign 4 ;						\

	.long (from) - . ;					\

	.long (to) - . ;					\

	.long (handler) - . ;					\

	ASM_EXTABLE_HANDLE from to handler



.macro ASM_EXTABLE_HANDLE from:req to:req handler:req

	.pushsection "__ex_table","a"

	.balign 4

	.long (\from) - .

	.long (\to) - .

	.long (\handler) - .

	.popsection

.endm

#else /* __ASSEMBLY__ */



# define _ASM_EXTABLE_HANDLE(from, to, handler)			\

	"ASM_EXTABLE_HANDLE from=" #from " to=" #to		\

	" handler=\"" #handler "\"\n\t"



/* For C file, we already have NOKPROBE_SYMBOL macro */



#endif /* __ASSEMBLY__ */



# define _ASM_EXTABLE(from, to)					\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_default)
@@ -148,6 +161,7 @@ 
	_ASM_PTR (entry);					\

	.popsection



#ifdef __ASSEMBLY__

.macro ALIGN_DESTINATION

	/* check for bad alignment of destination */

	movl %edi,%ecx
@@ -171,34 +185,7 @@ 
	_ASM_EXTABLE_UA(100b, 103b)

	_ASM_EXTABLE_UA(101b, 103b)

	.endm



#else

# define _EXPAND_EXTABLE_HANDLE(x) #x

# define _ASM_EXTABLE_HANDLE(from, to, handler)			\

	" .pushsection \"__ex_table\",\"a\"\n"			\

	" .balign 4\n"						\

	" .long (" #from ") - .\n"				\

	" .long (" #to ") - .\n"				\

	" .long (" _EXPAND_EXTABLE_HANDLE(handler) ") - .\n"	\

	" .popsection\n"



# define _ASM_EXTABLE(from, to)					\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_default)



# define _ASM_EXTABLE_UA(from, to)				\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_uaccess)



# define _ASM_EXTABLE_FAULT(from, to)				\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_fault)



# define _ASM_EXTABLE_EX(from, to)				\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_ext)



# define _ASM_EXTABLE_REFCOUNT(from, to)			\

	_ASM_EXTABLE_HANDLE(from, to, ex_handler_refcount)



/* For C file, we already have NOKPROBE_SYMBOL macro */

#endif

#endif /* __ASSEMBLY__ */



#ifndef __ASSEMBLY__

/*

arch/x86/kernel/macros.S

+1 −0
Original line number Diff line number Diff line
@@ -11,3 +11,4 @@ 
#include <asm/alternative-asm.h>

#include <asm/bug.h>

#include <asm/paravirt.h>

#include <asm/asm.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE