Commit 04614fe4 authored Jun 28, 2018 by Gustavo A. R. Silva Committed by Kalle Valo Jul 04, 2018

wlcore: Fix memory leak in wlcore_cmd_wait_for_event_or_timeout



In case memory resources for *events_vector* were allocated, release
them before return.

Addresses-Coverity-ID: 1470194 ("Resource leak")
Fixes: 4ec7cece ("wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 7444a809

drivers/net/wireless/ti/wlcore/cmd.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -195,8 +195,7 @@ int wlcore_cmd_wait_for_event_or_timeout(struct wl1271 *wl,
		ret = pm_runtime_get_sync(wl->dev);
		if (ret < 0) {
		pm_runtime_put_noidle(wl->dev);

		return ret;
		goto free_vector;
		}

		do {
		@@ -232,6 +231,7 @@ int wlcore_cmd_wait_for_event_or_timeout(struct wl1271 *wl,
		out:
		pm_runtime_mark_last_busy(wl->dev);
		pm_runtime_put_autosuspend(wl->dev);
		free_vector:
		kfree(events_vector);
		return ret;
		}

Admin message