Commit 045ee2d0 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

staging: mt7621-dma: Use struct_size() in devm_kzalloc()



One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 037e9edf
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -821,8 +821,8 @@ static int gdma_dma_probe(struct platform_device *pdev)
		return -EINVAL;
	data = (struct gdma_data *) match->data;

	dma_dev = devm_kzalloc(&pdev->dev, sizeof(*dma_dev) +
			(sizeof(struct gdma_dmaengine_chan) * data->chancnt),
	dma_dev = devm_kzalloc(&pdev->dev,
			       struct_size(dma_dev, chan, data->chancnt),
			       GFP_KERNEL);
	if (!dma_dev) {
		dev_err(&pdev->dev, "alloc dma device failed\n");