Unverified Commit 044ac826 authored by Miquel Raynal's avatar Miquel Raynal Committed by Mark Brown
Browse files

spi: zynq-qspi: Enhance the Linear CFG bit definitions 



Using masks makes sense when manipulating fields of several bits. When
only one bit is involved, it is usual to just use the BIT() macro but
in this case using the term mask is abusive. Fix the #define macros
and their comments.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20191108140744.1734-5-miquel.raynal@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 941be723

drivers/spi/spi-zynq-qspi.c

+3 −3
Original line number Diff line number Diff line
@@ -98,9 +98,9 @@ 
 * It is named Linear Configuration but it controls other modes when not in

 * linear mode also.

 */

#define ZYNQ_QSPI_LCFG_TWO_MEM_MASK	BIT(30) /* LQSPI Two memories Mask */

#define ZYNQ_QSPI_LCFG_SEP_BUS_MASK	BIT(29) /* LQSPI Separate bus Mask */

#define ZYNQ_QSPI_LCFG_U_PAGE_MASK	BIT(28) /* LQSPI Upper Page Mask */

#define ZYNQ_QSPI_LCFG_TWO_MEM		BIT(30) /* LQSPI Two memories */

#define ZYNQ_QSPI_LCFG_SEP_BUS		BIT(29) /* LQSPI Separate bus */

#define ZYNQ_QSPI_LCFG_U_PAGE		BIT(28) /* LQSPI Upper Page */



#define ZYNQ_QSPI_LCFG_DUMMY_SHIFT	8

CRA Git | Maintained and supported by SUSTech CRA and CCSE