Commit 04127372 authored by Sanjana Sanikommu's avatar Sanjana Sanikommu Committed by Greg Kroah-Hartman
Browse files

staging: gasket: apex: Prefer using the BIT macro 



Challenge suggested by coccinelle.

Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:

@@
constant c;
@@

-(1 << c)
+BIT(c)

Signed-off-by: default avatarSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bdcca44e

drivers/staging/gasket/apex_driver.c

+2 −2
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ static int apex_enter_reset(struct gasket_dev *gasket_dev) 


	/*    - Wait for RAM shutdown. */

	if (gasket_wait_with_reschedule(gasket_dev, APEX_BAR_INDEX,

					APEX_BAR2_REG_SCU_3, 1 << 6, 1 << 6,

					APEX_BAR2_REG_SCU_3, BIT(6), BIT(6),

					APEX_RESET_DELAY, APEX_RESET_RETRY)) {

		dev_err(gasket_dev->dev,

			"RAM did not shut down within timeout (%d ms)\n",
@@ -340,7 +340,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev) 


	/*    - Wait for RAM enable. */

	if (gasket_wait_with_reschedule(gasket_dev, APEX_BAR_INDEX,

					APEX_BAR2_REG_SCU_3, 1 << 6, 0,

					APEX_BAR2_REG_SCU_3, BIT(6), 0,

					APEX_RESET_DELAY, APEX_RESET_RETRY)) {

		dev_err(gasket_dev->dev,

			"RAM did not enable within timeout (%d ms)\n",

CRA Git | Maintained and supported by SUSTech CRA and CCSE