Commit 03f1df7d authored Oct 26, 2010 by Joe Perches Committed by Linus Torvalds Oct 26, 2010

checkpatch: Add additional attribute #defines



On Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:
> I just got this from a patch I merged..
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:
> +static struct pcc_cpu __percpu *pcc_cpu_info;
>                                 ^
> which doesn't seem right.

Perhaps these need to be added to checkpatch.

[apw@canonical.com: added tests]
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3bf9a009

scripts/checkpatch.pl

+14 −0

Original line number	Diff line number	Diff line
		@@ -152,6 +152,20 @@ our $Sparse = qr{
		# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
		our $Attribute = qr{
		const\|
		__percpu\|
		__nocast\|
		__safe\|
		__bitwise__\|
		__packed__\|
		__packed2__\|
		__naked\|
		__maybe_unused\|
		__always_unused\|
		__noreturn\|
		__used\|
		__cold\|
		__noclone\|
		__deprecated\|
		__read_mostly\|
		__kprobes\|
		__(?:mem\|cpu\|dev\|)(?:initdata\|initconst\|init\b)\|

Original line number	Diff line number	Diff line
		@@ -152,6 +152,20 @@ our $Sparse = qr{
		# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
		our $Attribute = qr{
		const\|
		__percpu\|
		__nocast\|
		__safe\|
		__bitwise__\|
		__packed__\|
		__packed2__\|
		__naked\|
		__maybe_unused\|
		__always_unused\|
		__noreturn\|
		__used\|
		__cold\|
		__noclone\|
		__deprecated\|
		__read_mostly\|
		__kprobes\|
		__(?:mem\|cpu\|dev\|)(?:initdata\|initconst\|init\b)\|

Admin message