Commit 03e12617 authored Sep 15, 2013 by Oleg Nesterov Committed by Linus Torvalds Sep 17, 2013

tty: disassociate_ctty() sends the extra SIGCONT



Starting from v3.10 (probably commit f91e2590: "tty: Signal
foreground group processes in hangup") disassociate_ctty() sends SIGCONT
if tty && on_exit.  This breaks LSB test-suite, in particular test8 in
_exit.c and test40 in sigcon5.c.

Put the "!on_exit" check back to restore the old behaviour.

Review by Peter Hurley:
 "Yes, this regression was introduced by me in that commit.  The effect
  of the regression is that ptys will receive a SIGCONT when, in similar
  circumstances, ttys would not.

  The fact that two test vectors accidentally tripped over this
  regression suggests that some other apps may as well.

  Thanks for catching this"

Cc: stable@vger.kernel.org # v3.10+
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Karel Srot <ksrot@redhat.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent de0bc3df

drivers/tty/tty_io.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -854,6 +854,7 @@ void disassociate_ctty(int on_exit)
		struct pid *tty_pgrp = tty_get_pgrp(tty);
		if (tty_pgrp) {
		kill_pgrp(tty_pgrp, SIGHUP, on_exit);
		if (!on_exit)
		kill_pgrp(tty_pgrp, SIGCONT, on_exit);
		put_pid(tty_pgrp);
		}

Admin message