Commit 03c5a6e1 authored by Mel Gorman's avatar Mel Gorman
Browse files

mm: numa: Add pte updates, hinting and migration stats 



It is tricky to quantify the basic cost of automatic NUMA placement in a
meaningful manner. This patch adds some vmstats that can be used as part
of a basic costing model.

u    = basic unit = sizeof(void *)
Ca   = cost of struct page access = sizeof(struct page) / u
Cpte = Cost PTE access = Ca
Cupdate = Cost PTE update = (2 * Cpte) + (2 * Wlock)
	where Cpte is incurred twice for a read and a write and Wlock
	is a constant representing the cost of taking or releasing a
	lock
Cnumahint = Cost of a minor page fault = some high constant e.g. 1000
Cpagerw = Cost to read or write a full page = Ca + PAGE_SIZE/u
Ci = Cost of page isolation = Ca + Wi
	where Wi is a constant that should reflect the approximate cost
	of the locking operation
Cpagecopy = Cpagerw + (Cpagerw * Wnuma) + Ci + (Ci * Wnuma)
	where Wnuma is the approximate NUMA factor. 1 is local. 1.2
	would imply that remote accesses are 20% more expensive

Balancing cost = Cpte * numa_pte_updates +
		Cnumahint * numa_hint_faults +
		Ci * numa_pages_migrated +
		Cpagecopy * numa_pages_migrated

Note that numa_pages_migrated is used as a measure of how many pages
were isolated even though it would miss pages that failed to migrate. A
vmstat counter could have been added for it but the isolation cost is
pretty marginal in comparison to the overall cost so it seemed overkill.

The ideal way to measure automatic placement benefit would be to count
the number of remote accesses versus local accesses and do something like

	benefit = (remote_accesses_before - remove_access_after) * Wnuma

but the information is not readily available. As a workload converges, the
expection would be that the number of remote numa hints would reduce to 0.

	convergence = numa_hint_faults_local / numa_hint_faults
		where this is measured for the last N number of
		numa hints recorded. When the workload is fully
		converged the value is 1.

This can measure if the placement policy is converging and how fast it is
doing it.

Signed-off-by: default avatarMel Gorman <mgorman@suse.de>
Acked-by: default avatarRik van Riel <riel@redhat.com>
parent 4b96a29b

include/linux/vm_event_item.h

+6 −0
Original line number Diff line number Diff line
@@ -38,6 +38,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, 
		KSWAPD_LOW_WMARK_HIT_QUICKLY, KSWAPD_HIGH_WMARK_HIT_QUICKLY,

		KSWAPD_SKIP_CONGESTION_WAIT,

		PAGEOUTRUN, ALLOCSTALL, PGROTATED,

#ifdef CONFIG_NUMA_BALANCING

		NUMA_PTE_UPDATES,

		NUMA_HINT_FAULTS,

		NUMA_HINT_FAULTS_LOCAL,

		NUMA_PAGE_MIGRATE,

#endif

#ifdef CONFIG_MIGRATION

		PGMIGRATE_SUCCESS, PGMIGRATE_FAIL,

#endif

include/linux/vmstat.h

+8 −0
Original line number Diff line number Diff line
@@ -80,6 +80,14 @@ static inline void vm_events_fold_cpu(int cpu) 


#endif /* CONFIG_VM_EVENT_COUNTERS */



#ifdef CONFIG_NUMA_BALANCING

#define count_vm_numa_event(x)     count_vm_event(x)

#define count_vm_numa_events(x, y) count_vm_events(x, y)

#else

#define count_vm_numa_event(x) do {} while (0)

#define count_vm_numa_events(x, y) do {} while (0)

#endif /* CONFIG_NUMA_BALANCING */



#define __count_zone_vm_events(item, zone, delta) \

		__count_vm_events(item##_NORMAL - ZONE_NORMAL + \

		zone_idx(zone), delta)

mm/huge_memory.c

+5 −0
Original line number Diff line number Diff line
@@ -1026,6 +1026,7 @@ int do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 
	struct page *page = NULL;

	unsigned long haddr = addr & HPAGE_PMD_MASK;

	int target_nid;

	int current_nid = -1;



	spin_lock(&mm->page_table_lock);

	if (unlikely(!pmd_same(pmd, *pmdp)))
@@ -1034,6 +1035,10 @@ int do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 
	page = pmd_page(pmd);

	get_page(page);

	spin_unlock(&mm->page_table_lock);

	current_nid = page_to_nid(page);

	count_vm_numa_event(NUMA_HINT_FAULTS);

	if (current_nid == numa_node_id())

		count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);



	target_nid = mpol_misplaced(page, vma, haddr);

	if (target_nid == -1)

mm/memory.c

+12 −0
Original line number Diff line number Diff line
@@ -3477,6 +3477,7 @@ int do_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 
	set_pte_at(mm, addr, ptep, pte);

	update_mmu_cache(vma, addr, ptep);



	count_vm_numa_event(NUMA_HINT_FAULTS);

	page = vm_normal_page(vma, addr, pte);

	if (!page) {

		pte_unmap_unlock(ptep, ptl);
@@ -3485,6 +3486,8 @@ int do_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 


	get_page(page);

	current_nid = page_to_nid(page);

	if (current_nid == numa_node_id())

		count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);

	target_nid = mpol_misplaced(page, vma, addr);

	pte_unmap_unlock(ptep, ptl);

	if (target_nid == -1) {
@@ -3517,6 +3520,9 @@ static int do_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 
	unsigned long offset;

	spinlock_t *ptl;

	bool numa = false;

	int local_nid = numa_node_id();

	unsigned long nr_faults = 0;

	unsigned long nr_faults_local = 0;



	spin_lock(&mm->page_table_lock);

	pmd = *pmdp;
@@ -3565,10 +3571,16 @@ static int do_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, 
		curr_nid = page_to_nid(page);

		task_numa_fault(curr_nid, 1);



		nr_faults++;

		if (curr_nid == local_nid)

			nr_faults_local++;



		pte = pte_offset_map_lock(mm, pmdp, addr, &ptl);

	}

	pte_unmap_unlock(orig_pte, ptl);



	count_vm_numa_events(NUMA_HINT_FAULTS, nr_faults);

	count_vm_numa_events(NUMA_HINT_FAULTS_LOCAL, nr_faults_local);

	return 0;

}

#else

mm/mempolicy.c

+2 −0
Original line number Diff line number Diff line
@@ -583,6 +583,8 @@ unsigned long change_prot_numa(struct vm_area_struct *vma, 
	BUILD_BUG_ON(_PAGE_NUMA != _PAGE_PROTNONE);



	nr_updated = change_protection(vma, addr, end, vma->vm_page_prot, 0, 1);

	if (nr_updated)

		count_vm_numa_events(NUMA_PTE_UPDATES, nr_updated);



	return nr_updated;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE