Commit 03b1a062 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: osd_uld: remove an unneeded NULL check 



We don't call the remove() function unless probe() succeeds so "oud"
can't be NULL here.  Plus, if it were NULL, we dereference it on the
next line so it would crash anyway.

[mkp: applied by hand]

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarBoaz Harrosh <ooo@electrozaur.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 16a20b52

drivers/scsi/osd/osd_uld.c

+3 −4
Original line number Diff line number Diff line
@@ -524,10 +524,9 @@ static int osd_remove(struct device *dev) 
	struct scsi_device *scsi_device = to_scsi_device(dev);

	struct osd_uld_device *oud = dev_get_drvdata(dev);



	if (!oud || (oud->od.scsi_device != scsi_device)) {

		OSD_ERR("Half cooked osd-device %p,%p || %p!=%p",

			dev, oud, oud ? oud->od.scsi_device : NULL,

			scsi_device);

	if (oud->od.scsi_device != scsi_device) {

		OSD_ERR("Half cooked osd-device %p, || %p!=%p",

			dev, oud->od.scsi_device, scsi_device);

	}



	device_unregister(&oud->class_dev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE